Hi, On Thu, Aug 09, 2018 at 01:42:09PM +0200, Christophe Fergeau wrote: > Hey, > > Aside for these signed-of-by issues (would be nice if we had one from > the original author, but we don't strictly enforce the use of it in > spice in general, and imo no s-o-b is better than patch submitted > anonymously), the patch looks good to me, so > Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx> Thanks, I'll push it shortly. > On Tue, Aug 07, 2018 at 01:01:44PM +0200, Victor Toso wrote: > > Hi Daniel, > > > > Thanks for the clarification. > > > > On Tue, Aug 07, 2018 at 11:35:00AM +0100, Daniel P. Berrangé wrote: > > > On Tue, Aug 07, 2018 at 06:25:05AM -0400, Frediano Ziglio wrote: > > > > > > > > > > Hi, > > > > > > > > > > On Tue, Aug 07, 2018 at 06:02:41AM -0400, Frediano Ziglio wrote: > > > > > > > > > > > > > > From: 王凡 <wangfan1987.good@xxxxxxx> > > > > > > > > > > > > > > In libusb 1.0.21, UsbDk is enabled at compile time with --enable-usbdk > > > > > > > option. In libusb 1.0.22, the backend is selected at runtime. > > > > > > > > > > > > > > This patch avoids a crash when spice client is compiled against libusb > > > > > > > 1.0.22 and UsbDk is not installed. > > > > > > > > > > > > > > * Enabling dynamic backend selection in Windows > > > > > > > https://github.com/libusb/libusb/commit/54884e84d024e761450287ab56aca > > > > > > > > > > > > > > https://gitlab.freedesktop.org/spice/spice-gtk/issues/74 > > > > > > > Signed-off-by: Victor Toso <victortoso@xxxxxxxxxx> > > > > > > > > > > > > No signed off by 王凡 (I know is the author) ? > > > > > > > > > > Is it a hard requirement when the person is author of patch? > > > > > > > > Not sure, that's why the question. In some cases the signed-off is used > > > > for licenses issues (like saying "I, the author, allow the owner to change > > > > license" or something similar). > > > > > > The "Signed-off-by" tag is an attestation the person signing > > > that the work complies with https://developercertificate.org/ > > > > > > It it not a hard requirement for the original patch author to > > > have provided a sign-off, but the implication is that in such > > > cases the non-author who does apply a sign off is saying that > > > they believe the original author has complied with the rules in > > > the DCO. > > > > I see now, my mistake. > > > > The reason I put S-o-B was that I changed the patch and included > > the commit log. > > > > > So here Victor is attesting that he believes 王凡 was in > > > compliance with the DCO when submitting the patch. How Victor > > > has such confidence is up to him to decide - the easy way is to > > > have required the original author to provide a S-o-B :-) This > > > patch, however, is trivial and is exactly what any author would > > > have written for the stated problem. > > > > Thanks, > > Victor > > > > > _______________________________________________ > > Spice-devel mailing list > > Spice-devel@xxxxxxxxxxxxxxxxxxxxx > > https://lists.freedesktop.org/mailman/listinfo/spice-devel >
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel