Hi On Mon, Aug 6, 2018 at 10:20 AM, Jakub Jelen <jjelen@xxxxxxxxxx> wrote: > On Fri, 2018-08-03 at 15:00 +0200, Marc-André Lureau wrote: >> Hi >> >> On Fri, Aug 3, 2018 at 12:40 PM, <marcandre.lureau@xxxxxxxxxx> >> wrote: >> > From: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx> >> > >> > use_hw=yes is used to specify that libcacard will lookup pkcs11 >> > slots >> > that are both removable & hardware. >> > >> > Let's specify that use_hw=removable will select removable slots >> > (without hardware requirement). >> > >> > (use_hw= should eventually be changed/aliased to pk11_slots= or >> > something else) >> > >> > Signed-off-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx> >> >> I updated "tests: Create separate hardware tests" to make use of >> this, >> and fixed make check/distcheck along: >> >> > https://gitlab.freedesktop.org/elmarco/libcacard/commit/5ee1734824f0b8baf4b6800a61426c46f7ea62be >> >> what do you think Jakub? > > Thank you for integrating that into the check target. The changes look > good. Only the commit message is a bit outdated, since the script no > longer takes care of running the tests and the nss db is automatically > created by the script. > fixed > This makes it good for the CI, but prevents from running the tests > against a real card so I would like to see a new target check-local or > hwcheck to skip the softhsm part and use some local NSS DB with real > PKCS#11 module, but that can come in separate commit later. > Red Hat, Inc. What does "prevents from running the test against a real card"? You should be able to run the hwtest manually against a local card. The default "make check" can't expect a real card. If needed, we could have a LIBCACARD_TEST= environment variable to tweak the test behaviour? (but how would it know how to setup hwdb for you?) -- Marc-André Lureau _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel