On Tue, 2018-07-31 at 20:07 +0200, Marc-André Lureau wrote: > Hi > > On Tue, Jul 31, 2018 at 4:49 PM, Jakub Jelen <jjelen@xxxxxxxxxx> > wrote: > > [...] > > -test_programs = tests/libcacard > > -tests_libcacard_LDADD = libcacard.la $(GTHREAD_LIBS) > > +test_programs = \ > > + tests/simpletlv \ > > + tests/libcacard > > +tests_libcacard_SOURCES = tests/libcacard.c > > +tests_libcacard_LDADD = libcacard.la \ > > + src/common.lo \ > > + src/simpletlv.lo \ > > + $(GTHREAD_LIBS) > > Why do you change tests/libcacard linking ? > > I'll touch on commit Right. Thanks. This should come in later stages, when the simpletlv is used from the libcacard testsuite itself. > > +tests_simpletlv_LDADD = src/common.lo \ > > + src/simpletlv.lo \ > > + $(GTHREAD_LIBS) > > I am not fond of linking with libtool objects. We should use > convenience libraries, but let's not bother with that for now. I was not quite sure how to do that better. If you have better solution, I am open for proposals. Jakub _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel