Re: [PATCH libcacard 44/45] Set up the CI in gitlab including coverage reports

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2018-07-31 at 18:14 +0200, Marc-André Lureau wrote:
> Hi
> 
> On Tue, Jul 31, 2018 at 4:50 PM, Jakub Jelen <jjelen@xxxxxxxxxx>
> wrote:
> > Signed-off-by: Jakub Jelen <jjelen@xxxxxxxxxx>
> > Reviewed-by: Robert Relyea <rrelyea@xxxxxxxxxx>
> > ---
> >  .gitlab-ci.yml | 53
> > ++++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 53 insertions(+)
> >  create mode 100644 .gitlab-ci.yml
> > 
> 
> This will pass on freedesktop instance with the following changes:
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 7eb7a22..5910594 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -1,3 +1,9 @@
> +image: fedora:latest
> +
> +before_script:
> +  - dnf update -y
> +  - dnf install -y gcc automake libtool make pkgconfig
> autoconf-archive nss-devel glib2-devel opensc gnutls-utils nss-tools
> openssl softhsm lcov
> +
>  .base: &base_job
>    artifacts:
>      expire_in: '1 week'
> @@ -24,8 +30,6 @@ Check:
>      - bash run_tests.sh
>      - make code-coverage-capture
>      - lcov --summary libcacard-*-coverage.info
> -  tags:
> -    - linux
> 
>  Memcheck:
>    <<: *base_job
> @@ -35,8 +39,6 @@ Memcheck:
>      - ./configure
>      - sed -e "s/make check/make memcheck-local/" -i run_tests.sh
>      - bash run_tests.sh
> -  tags:
> -    - linux
>    allow_failure: true
> 
> 
> 
> (ideally, we would use a saved docker instead of reinstalling)
> 
> Do you mind if I squash the changes and push this patch before the
> rest of the series?

Sure. Feel free to squash this first. The reason I did this later was
that the testsuite was very limited before I started working on that.

> thanks
> 
> > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > new file mode 100644
> > index 0000000..7eb7a22
> > --- /dev/null
> > +++ b/.gitlab-ci.yml
> > @@ -0,0 +1,53 @@
> > +.base: &base_job
> > +  artifacts:
> > +    expire_in: '1 week'
> > +    paths:
> > +      - test-suite.log
> > +      - libcacard-*-coverage
> > +  only:
> > +    - master
> > +
> > +Build:
> > +  <<: *base_job
> > +  stage: build
> > +  script:
> > +    - autoreconf -i
> > +    - ./configure
> > +    - make
> > +
> > +Check:
> > +  <<: *base_job
> > +  stage: test
> > +  script:
> > +    - autoreconf -i
> > +    - ./configure --enable-code-coverage
> > +    - bash run_tests.sh
> > +    - make code-coverage-capture
> > +    - lcov --summary libcacard-*-coverage.info
> > +  tags:
> > +    - linux
> > +
> > +Memcheck:
> > +  <<: *base_job
> > +  stage: test
> > +  script:
> > +    - autoreconf -i
> > +    - ./configure
> > +    - sed -e "s/make check/make memcheck-local/" -i run_tests.sh
> > +    - bash run_tests.sh
> > +  tags:
> > +    - linux
> > +  allow_failure: true
> > +
> > +pages:
> > +  stage: deploy
> > +  dependencies:
> > +    - Check
> > +  script:
> > +    - mv *-coverage/ public/
> > +  artifacts:
> > +    paths:
> > +      - public
> > +    expire_in: 30 days
> > +  only:
> > +    - master
> > --
> > 2.17.1
> > 
> > _______________________________________________
> > Spice-devel mailing list
> > Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> > https://lists.freedesktop.org/mailman/listinfo/spice-devel
> 
> 
> 
-- 
Jakub Jelen
Software Engineer
Security Technologies
Red Hat, Inc.

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]