Hi supression/suppression On Tue, Jul 31, 2018 at 4:50 PM, Jakub Jelen <jjelen@xxxxxxxxxx> wrote: > Signed-off-by: Jakub Jelen <jjelen@xxxxxxxxxx> > Reviewed-by: Robert Relyea <rrelyea@xxxxxxxxxx> > --- > build-aux/glib-tap.mk | 2 +- > build-aux/glib.supp | 35 +++++++++++++++++++ > build-aux/nss.supp | 81 +++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 117 insertions(+), 1 deletion(-) > create mode 100644 build-aux/glib.supp > create mode 100644 build-aux/nss.supp > > diff --git a/build-aux/glib-tap.mk b/build-aux/glib-tap.mk > index b63d6c9..5fc48ff 100644 > --- a/build-aux/glib-tap.mk > +++ b/build-aux/glib-tap.mk > @@ -137,9 +137,9 @@ endif > > VALGRIND_ARGS = \ > --leak-check=full \ > - --show-leak-kinds=all \ > --child-silent-after-fork=yes \ > --suppressions=$(abs_top_srcdir)/build-aux/glib.supp \ Let's reference glib-devel installed /usr/share/glib-2.0/valgrind/glib.supp > + --suppressions=$(abs_top_srcdir)/build-aux/nss.supp \ sadly, nss doesn't ship it's own suppression file. Fine to have our own. Should we also open a bug to NSS or as those warnings caused by libcacard? I'll touch on commit. Thanks > --num-callers=18 \ > $(NULL) > > diff --git a/build-aux/glib.supp b/build-aux/glib.supp > new file mode 100644 > index 0000000..ff2edbe > --- /dev/null > +++ b/build-aux/glib.supp > @@ -0,0 +1,35 @@ > +{ > + _dl_init > + Memcheck:Leak > + match-leak-kinds: reachable > + fun:*alloc > + ... > + fun:_dl_init > + obj:/usr/lib64/ld-2.26.so > + ... > +} > +{ > + g_rand_new_with_seed_array > + Memcheck:Leak > + match-leak-kinds: reachable > + fun:calloc > + fun:g_malloc0 > + fun:g_rand_new_with_seed_array > + ... > + fun:main > +} > +{ > + pthread_create > + Memcheck:Leak > + match-leak-kinds: possible > + fun:calloc > + fun:allocate_dtv > + fun:_dl_allocate_tls > + fun:pthread_create@@GLIBC_2.2.5 > + obj:/usr/lib64/libglib-2.0.so.0.5400.3 > + obj:/usr/lib64/libglib-2.0.so.0.5400.3 > + fun:g_thread_new > + fun:libcacard_init > + fun:main > +} > + > diff --git a/build-aux/nss.supp b/build-aux/nss.supp > new file mode 100644 > index 0000000..3ff8ff8 > --- /dev/null > +++ b/build-aux/nss.supp > @@ -0,0 +1,81 @@ > +{ > + PK11_FindCertFromNickname > + Memcheck:Leak > + match-leak-kinds: reachable > + fun:*alloc > + ... > + fun:PK11_FindCertFromNickname > + ... > +} > +{ > + PK11_FindCertFromNickname > + Memcheck:Leak > + match-leak-kinds: possible > + fun:*alloc > + ... > + fun:PK11_FindCertFromNickname > + ... > +} > +{ > + SECMOD_LoadModule > + Memcheck:Leak > + match-leak-kinds: reachable > + fun:*alloc > + ... > + obj:/usr/lib64/libnss3.so > + fun:SECMOD_LoadModule > + fun:SECMOD_LoadModule > + ... > +} > +{ > + NSS_Init > + Memcheck:Leak > + match-leak-kinds: possible > + fun:*alloc > + ... > + fun:NSS_Init > + fun:vcard_emul_init > + fun:libcacard_init > + ... > +} > +{ > + NSS_Init > + Memcheck:Leak > + match-leak-kinds: definite > + fun:*alloc > + ... > + fun:NSS_Init > + fun:vcard_emul_init > + fun:libcacard_init > + ... > +} > +{ > + NSS_Init > + Memcheck:Leak > + match-leak-kinds: reachable > + fun:*alloc > + ... > + fun:NSS_Init > + fun:vcard_emul_init > + fun:libcacard_init > + ... > +} > +{ > + PR_LoadLibraryWithFlags > + Memcheck:Leak > + match-leak-kinds: reachable > + fun:calloc > + ... > + fun:PR_LoadLibraryWithFlags > + ... > +} > +{ > + softokn > + Memcheck:Leak > + match-leak-kinds: reachable > + fun:*alloc > + ... > + obj:/usr/lib64/libsoftokn3.so > + ... > +} > + > -- > 2.17.1 > > _______________________________________________ > Spice-devel mailing list > Spice-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/spice-devel -- Marc-André Lureau _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel