Re: [PATCH spice-server] fixup! Update gitlab-ci to use meson

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/25/2018 12:36 PM, Frediano Ziglio wrote:
Fix printf command.
Version is not used as a quoted string but as a number
(see resulting spice-version.h)

Looks good to me.

Note that it's a fixup for patch [1/2]
 "Add support for building with meson/ninja"

Uri.

---
  server/meson.build | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/server/meson.build b/server/meson.build
index 707551e5b..0b89acb04 100644
--- a/server/meson.build
+++ b/server/meson.build
@@ -11,7 +11,7 @@ if not version_info[3].contains('git')
    micro += 1
  endif
  micro = '@0@'.format(micro)
-cmd = run_command('printf', ['"0x%02x%02x%02x"', major, minor, micro], check : true)
+cmd = run_command('printf', ['0x%02x%02x%02x', major, minor, micro], check : true)
  version_data = configuration_data()
  version_data.set('SPICE_SERVER_VERSION', cmd.stdout().strip())
  spice_version_h = configure_file(input : 'spice-version.h.in',


_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]