Re: [PATCH v2 2/2] Fix clang build error on missing <errno.h>

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 17, 2018 at 05:56:15PM +0200, Christophe de Dinechin wrote:
> From: Christophe de Dinechin <dinechin@xxxxxxxxxx>
> 
> Using errno requires <errno.h>. Some platforms/compilers
> are stricter than others in this respect.
> 
> frame-log.cpp:27:96: error: use of undeclared identifier 'errno'
>            throw Error(std::string("Failed to open log file '") + log_name + "': " + strerror(errno));
> 
> Signed-off-by: Christophe de Dinechin <dinechin@xxxxxxxxxx>
> ---
>  src/frame-log.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/frame-log.cpp b/src/frame-log.cpp
> index 63a8ac0..cc993cd 100644
> --- a/src/frame-log.cpp
> +++ b/src/frame-log.cpp
> @@ -12,6 +12,7 @@
>  #include <chrono>
>  #include <cstdarg>
>  #include <string.h>
> +#include <errno.h>

I'd try to keep this list alphabetically ordered

Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx>

Christophe

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]