> > As an independent step in the monitors_config series, the SpiceHead::id > can be renamed to monitor_id. > > Note the spice-server and spice-gtk patches should contain an update to > the spice-common submodule referencing the commit that does the rename, > so that the repository is in a consistent state. I'm not sure how to do > this as it requires pushing the spice-common commit first and then > updating the other two patches... > As a rule we don't want commits that do not compile so the spice-server/spice-gtk commit should also contains update to spice-common submodule. Just include them into commit (usually we do it with the shortlog, maybe would be worth this time having a submodule update without last commit and another with field rename and spice-server/spice-gtk required update). You don't need a push but just the commit hash (so git commit). Should be up to the committer updating the hash if needed before finally pushing upstream. Frediano _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel