Hey Christophe,
On 07/12/2018 11:07 AM, Christophe Fergeau wrote:
log_draw() is used to debug drawing commands by dumping drawing
information to the JS console. This commit adds dumping of missing data
for uncompressed bitmaps. The 'stride' parameter is important, as
spice-html5 currently does not deal properly with such bitmaps.
Signed-off-by: Christophe Fergeau <cfergeau@xxxxxxxxxx>
---
display.js | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/display.js b/display.js
index 7719b23..c55b686 100644
--- a/display.js
+++ b/display.js
@@ -769,6 +769,12 @@ SpiceDisplayConn.prototype.log_draw = function(prefix, draw)
str += "; src_bitmap type " + draw.data.src_bitmap.descriptor.type + ", flags " + draw.data.src_bitmap.descriptor.flags;
if (draw.data.src_bitmap.surface_id !== undefined)
str += "; src_bitmap surface_id " + draw.data.src_bitmap.surface_id;
+ if (draw.data.src_bitmap.bitmap)
+ str += "; BITMAP format " + draw.data.src_bitmap.bitmap.format +
+ "; flags " + draw.data.src_bitmap.bitmap.format +
That looks like a repeat of the format, rather than the flags.
The patch otherwise seems great to me.
Cheers,
Jeremy
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel