When GstVideoOverly is used there is no appsink, playing of a frame is done according the time value of its buffer --- Currently no error will happen since counting pending frames is not done and that will cause some checks will to fail and avoid critic error. but should be safer to return here. Is somthing else need to be done in case of reschedule when gstvideooverlay is used? --- src/channel-display-gst.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c index 1ccc788..dad49cf 100644 --- a/src/channel-display-gst.c +++ b/src/channel-display-gst.c @@ -512,6 +512,10 @@ static gboolean create_pipeline(SpiceGstDecoder *decoder) static void spice_gst_decoder_reschedule(VideoDecoder *video_decoder) { SpiceGstDecoder *decoder = (SpiceGstDecoder*)video_decoder; + + if (!decoder->appsink) { + return; + } guint timer_id; g_mutex_lock(&decoder->queues_mutex); -- 2.17.0 _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel