> On 5 Jul 2018, at 15:14, Jonathon Jongsma <jjongsma@xxxxxxxxxx> wrote:
>
> On Mon, 2018-07-02 at 11:35 -0400, Frediano Ziglio wrote:
>>>
>>>> On 2 Jul 2018, at 09:43, Frediano Ziglio <fziglio@xxxxxxxxxx>
>>>> wrote:
>>>>
>>>> As the value is never used we can pass NULL in CreateThread.
>>>>
>>>> Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx>
>>>> ---
>>>> vdagent/vdagent.cpp | 3 +--
>>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>>>
>>>> diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp
>>>> index 91e5f36..f25f9f3 100644
>>>> --- a/vdagent/vdagent.cpp
>>>> +++ b/vdagent/vdagent.cpp
>>>> @@ -254,7 +254,6 @@ DWORD WINAPI
>>>> VDAgent::event_thread_proc(LPVOID param)
>>>> bool VDAgent::run()
>>>> {
>>>> DWORD session_id;
>>>> - DWORD event_thread_id;
>>>> HANDLE event_thread;
>>>> WNDCLASS wcls;
>>>>
>>>> @@ -318,7 +317,7 @@ bool VDAgent::run()
>>>> return false;
>>>> }
>>>> _running = true;
>>>> - event_thread = CreateThread(NULL, 0, event_thread_proc,
>>>> this, 0,
>>>> &event_thread_id);
>>>> + event_thread = CreateThread(NULL, 0, event_thread_proc,
>>>> this, 0,
>>>> NULL);
>>>
>>> Might be useful for debugging, though…
>>>
>>
>> It's easier to use process explorer or other similar tools,
>> also considering that we don't provide standard (visual studio one)
>> debugging information.
>>
>>>> if (!event_thread) {
>>>> vd_printf("CreateThread() failed: %lu", GetLastError());
>>>> return false;
>>
>> Frediano
>> _______________________________________________
>> Spice-devel mailing list
>> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
>> https://lists.freedesktop.org/mailman/listinfo/spice-devel
>
>
> OK with me. Unless Christophe feels strongly,
If I’m the Christophe, I’m not strongly against, just don’t see much value.
>
> Acked-by: Jonathon Jongsma <jjongsma@xxxxxxxxxx>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel