Re: [PATCH] Set default syslog mask to a lower level

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi


On 06/28/2018 03:47 PM, Frediano Ziglio wrote:
This will allow printing run-time information to stderr (by using
LOG_NOTICE level) without classifying it as warning/error or by
enabling debug mode.
Seems reasonable

---
  src/spice-streaming-agent.cpp | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

This follows a suggestion to print run-time informative logs coming from
This seems not much reasonable. What are "run-time informative logs"?
Seems more something for LOG_INFO from the description.
For these a not default option (there is a similar option for LOG_DEBUG)
seems better.

Both LOG_DEBUG and LOG_INFO will me masked in both cases,
which is not my intent.
I will add this patch to the v3 series of the gst-plugin, it will be more clear
that way.

Thanks, Snir.


the gst-plugin using syslog instead of printing it directly to stdout.


diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp
index 67679ac..2625211 100644
--- a/src/spice-streaming-agent.cpp
+++ b/src/spice-streaming-agent.cpp
@@ -435,7 +435,7 @@ int main(int argc, char* argv[])
      openlog("spice-streaming-agent",
              isatty(fileno(stderr)) ? (LOG_PERROR|LOG_PID) : LOG_PID,
              LOG_USER);
- setlogmask(LOG_UPTO(LOG_WARNING));
+    setlogmask(LOG_UPTO(LOG_NOTICE));
while ((opt = getopt_long(argc, argv, "hp:c:l:d", long_options, NULL))
      != -1) {
          switch (opt) {
Frediano

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]