[spice-common v3 6/6] test-region: Add g_assert() checks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At the moment, test success/failure is only printed to stdout. This
commit adds some g_assert() so that test failures can be automatically
detected.
---
 tests/test-region.c | 21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)

diff --git a/tests/test-region.c b/tests/test-region.c
index ec451c4..0fe9e82 100644
--- a/tests/test-region.c
+++ b/tests/test-region.c
@@ -103,19 +103,29 @@ static void test(const QRegion *r1, const QRegion *r2, int *expected)
 {
     g_debug("r1 is_empty %s [%s]",
             region_is_empty(r1) ? "TRUE" : "FALSE",
-            (region_is_empty(r1) == *(expected++)) ? "OK" : "ERR");
+            (region_is_empty(r1) == *expected) ? "OK" : "ERR");
+    g_assert_cmpint(region_is_empty(r1), ==, *expected);
+    expected++;
     g_debug("r2 is_empty %s [%s]",
             region_is_empty(r2) ? "TRUE" : "FALSE",
-            (region_is_empty(r2) == *(expected++)) ? "OK" : "ERR");
+            (region_is_empty(r2) == *expected) ? "OK" : "ERR");
+    g_assert_cmpint(region_is_empty(r2), ==, *expected);
+    expected++;
     g_debug("is_equal %s [%s]",
             region_is_equal(r1, r2) ? "TRUE" : "FALSE",
-            (region_is_equal(r1, r2) == *(expected++)) ? "OK" : "ERR");
+            (region_is_equal(r1, r2) == *expected) ? "OK" : "ERR");
+    g_assert_cmpint(region_is_equal(r1, r2), ==, *expected);
+    expected++;
     g_debug("intersects %s [%s]",
             region_intersects(r1, r2) ? "TRUE" : "FALSE",
-            (region_intersects(r1, r2) == *(expected++)) ? "OK" : "ERR");
+            (region_intersects(r1, r2) == *expected) ? "OK" : "ERR");
+    g_assert_cmpint(region_intersects(r1, r2), ==, *expected);
+    expected++;
     g_debug("contains %s [%s]",
             region_contains(r1, r2) ? "TRUE" : "FALSE",
-            (region_contains(r1, r2) == *(expected++)) ? "OK" : "ERR");
+            (region_contains(r1, r2) == *expected) ? "OK" : "ERR");
+    g_assert_cmpint(region_contains(r1, r2), ==, *expected);
+    expected++;
 }
 
 enum {
@@ -388,6 +398,7 @@ static void test_region(void)
                 g_debug("r2:");
                 region_dump(r2, "");
             }
+            g_assert_cmpint(res1, ==, res2);
             j++;
         }
     }
-- 
2.17.1

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]