Re: [RFC/POC PATCH vd_agent 13/16] vdagent: Log the diddly doo X11 error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> Signed-off-by: Lukáš Hrázký <lhrazky@xxxxxxxxxx>
> ---
>  src/vdagent/x11-randr.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/vdagent/x11-randr.c b/src/vdagent/x11-randr.c
> index 803cf73..84c75f2 100644
> --- a/src/vdagent/x11-randr.c
> +++ b/src/vdagent/x11-randr.c
> @@ -38,6 +38,10 @@
>  
>  static int error_handler(Display *display, XErrorEvent *error)
>  {
> +    char buf[1024];
> +    XGetErrorText(display, error->error_code, buf, 1024);
> +    syslog(LOG_ERR, "X11 Error: %s", buf);
> +
>      vdagent_x11_caught_error = 1;
>      return 0;
>  }

Beside the title too slang patch looks good but I suppose that this
function is here to catch error and ignore them so why logging as
error something already expected?

Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]