Re: [PATCH spice-gtk] channel-display: Avoid ABI incompatibility for streaming-mode signal

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,


On 05/23/2018 12:44 PM, Frediano Ziglio wrote:
Changing SpiceDisplayChannelClass structure causes ABI incompatibility.
Having a field for streaming-mode signal is not planned to be used
so remove it.

Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx>
---
  src/channel-display.c | 4 +---
  src/channel-display.h | 2 --
  2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/src/channel-display.c b/src/channel-display.c
index 3f2fb3dc..1c0021e8 100644
--- a/src/channel-display.c
+++ b/src/channel-display.c
@@ -470,9 +470,7 @@ static void spice_display_channel_class_init(SpiceDisplayChannelClass *klass)
      signals[SPICE_DISPLAY_STREAMING_MODE] =
          g_signal_new("streaming-mode",
                       G_OBJECT_CLASS_TYPE(gobject_class),
-                     0,
-                     G_STRUCT_OFFSET(SpiceDisplayChannelClass,
-                                     streaming_mode),
+                     0, 0,
                       NULL, NULL,
                       g_cclosure_user_marshal_POINTER__BOOLEAN,
                       G_TYPE_POINTER,
diff --git a/src/channel-display.h b/src/channel-display.h
index 9c51aa2a..31293094 100644
--- a/src/channel-display.h
+++ b/src/channel-display.h
@@ -141,8 +141,6 @@ struct _SpiceDisplayChannelClass {
                                 gint x, gint y, gint w, gint h);
      void (*display_mark)(SpiceChannel *channel,
                           gboolean mark);
-    void (*streaming_mode)(SpiceChannel *channel,
-                           gboolean streaming_mode);
/*< private >*/
  };

Ack, indeed, not really needed.
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]