Hi,
On 05/16/2018 05:16 PM, Frediano Ziglio wrote:
In case glimagesink is used (up to playbin) window system events
do not propagate to the widget. This patch tells the overlay not
to try handle window system events.
Which event? Did you had any issue? Kind of moving mouse/pressing keyboard
I suppose
Yes, i didn't get mouse motion events, when pipeline was using the nvdec
decoder, but it may
happen in other cases too (more likely when decoder's output supports
GlMemory).
Signed-off-by: Snir Sheriber <ssheribe@xxxxxxxxxx>
---
src/channel-display-gst.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c
index 3d0827a..9bc9f50 100644
--- a/src/channel-display-gst.c
+++ b/src/channel-display-gst.c
@@ -318,6 +318,7 @@ static gboolean handle_pipeline_message(GstBus *bus,
GstMessage *msg, gpointer v
if (decoder->win_handle != 0) {
overlay = GST_VIDEO_OVERLAY(GST_MESSAGE_SRC(msg));
gst_video_overlay_set_window_handle(overlay,
decoder->win_handle);
+ gst_video_overlay_handle_events (overlay, false);
Style: space before arguments.
ok
Thanks, Snir.
}
}
break;
Frediano
>From 7e064b01521557241029b852141083266dd956ad Mon Sep 17 00:00:00 2001
From: Snir Sheriber <ssheribe@xxxxxxxxxx>
Date: Wed, 16 May 2018 16:33:09 +0300
Subject: [PATCH] Gstreamer: Don't let overlay to handle windowing system
events
In case glimagesink is used (up to playbin) window system events
do not propagate to the widget. This patch tells the overlay not
to try handle window system events.
Signed-off-by: Snir Sheriber <ssheribe@xxxxxxxxxx>
---
src/channel-display-gst.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c
index 3d0827a..c0e6b17 100644
--- a/src/channel-display-gst.c
+++ b/src/channel-display-gst.c
@@ -318,6 +318,7 @@ static gboolean handle_pipeline_message(GstBus *bus, GstMessage *msg, gpointer v
if (decoder->win_handle != 0) {
overlay = GST_VIDEO_OVERLAY(GST_MESSAGE_SRC(msg));
gst_video_overlay_set_window_handle(overlay, decoder->win_handle);
+ gst_video_overlay_handle_events(overlay, false);
}
}
break;
--
2.17.0
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel