Hey, Currently, after parsing a QXL command through red-parse-qxl, the code which got the command has to tell red-parse-qxl when it no longer needs the command, but also to remember to release the command QXL resources itself. This series moves this 'release resource' logic to red-parse-qxl. Changes since v1: - moved renaming patch to the end, and made it much more extensive - added a new patch unifying identical methods - reworked 'qxl: Fix guest resources release in red_put_drawable()' so that it's similar to the cursor changes Christophe Christophe Fergeau (9): qxl: Remove red_put_blend() qxl: Remove 'blackness' and 'invers' put/get methods qxl: Move red_drawable_unref/red_drawable_new qxl: Make red_{get,put}_drawable static qxl: Fix guest resources release in red_put_drawable() qxl: Add red_cursor_cmd_new and red_cursor_cmd_free helpers qxl: Release QXL resource in red_put_message qxl: Release QXL resources in red_put_update_cmd qxl: Improve 'red' and 'qxl' argument names server/cursor-channel.c | 6 +- server/red-parse-qxl.c | 993 +++++++++++++++++++++------------------- server/red-parse-qxl.h | 19 +- server/red-worker.c | 47 +- server/tests/test-qxl-parsing.c | 37 +- 5 files changed, 558 insertions(+), 544 deletions(-) -- 2.14.3 _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel