Hey, On Tue, Apr 10, 2018 at 08:16:32AM -0400, Frediano Ziglio wrote: > > > > > > Ping? I would like to move forward with having this fix temporarily in > > > spice-server even if in the long run, we'll be fixing QEMU too. > > > This would ease the upgrade path, as having this patch means we don't > > > tie upgrades to spice-server 0.14 with QEMU upgrades, it does not matter > > > if you upgrade both at once or not, spice-server will have the same > > > behaviour as in the 0.12 branch. > > > > > > Christophe > > > > > > > When do you plan to remove this patch from spice-server? > > > > > On Thu, Apr 05, 2018 at 10:36:27AM +0200, Christophe Fergeau wrote: > > > > There's an implicit API/ABI contract between QEMU and SPICE that SPICE > > > > will keep the guest QXL resources alive as long as QEMU can hold a > > > > pointer to them. This implicit contract was broken in 1c6e7cf7 "Release > > > > cursor as soon as possible", causing crashes at migration time. > > > > While the proper fix would be in QEMU so that spice-server does not need > > > > to have that kind of knowledge regarding QEMU internal implementation, > > > > this commit reverts to the pre-1c6e7cf7 behaviour to avoid a regression > > > > while QEMU is being fixed. > > > > > > > > https://bugzilla.redhat.com/show_bug.cgi?id=1540919 > > > > > > > > Signed-off-by: Christophe Fergeau <cfergeau@xxxxxxxxxx> > > > > Would not be better to add a qxl field in RedCursorCmd and free the resource > > in red_put_cursor_cmd? > > This patch looks pretty invasive. > > > > Like: Yes, definitely a very good suggestion, I'll try that, thanks ! Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel