The name "com.redhat.stream.0" is too generic and in no way denotes it
belongs to SPICE.
Signed-off-by: Lukáš Hrázký <lhrazky@xxxxxxxxxx>
---
It would be better to name it something like "org.spice-space.stream.0"
but alas, we already have 'com.redhat.spice.0" and can hardly change
that.
Though we do also seem to have "org.spice-space.webdav.0"...
The server will need an update too, I'll do it if this gets acked.
README | 12 ++++++------
data/90-spice-guest-streaming.rules | 2 +-
src/spice-streaming-agent.cpp | 2 +-
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/README b/README
index 7e9a3c7..0d85916 100644
--- a/README
+++ b/README
@@ -13,7 +13,7 @@ Virtual Machine Configuration
=============================
In order to set up streaming, qemu needs to expose a
-`com.redhat.stream.0` virtio port, associated with a
+`com.redhat.spice.stream.0` virtio port, associated with a
corresponding Spice port.
Using virt-manager
@@ -21,8 +21,8 @@ Using virt-manager
In the hardware details, click on "Add Hardware", then select
"Channel". Add a "Spice port" device type with the
-"com.redhat.stream.0" name. You also need to set "Channel" to
-"com.redhat.stream.0"
+"com.redhat.spice.stream.0" name. You also need to set "Channel" to
+"com.redhat.spice.stream.0"
Using libvirt
@@ -31,8 +31,8 @@ Using libvirt
[source,xml]
<devices>
<channel type='spiceport'>
- <source channel='com.redhat.stream.0'/>
- <target type='virtio' name='com.redhat.stream.0'/>
+ <source channel='com.redhat.spice.stream.0'/>
+ <target type='virtio' name='com.redhat.spice.stream.0'/>
</channel>
</devices>
@@ -40,4 +40,4 @@ Using QEMU
----------
[source,sh]
--device virtserialport,bus=virtio-serial0.0,nr=1,chardev=charchannel1,id=channel1,name=com.redhat.stream.0 -chardev spiceport,name=com.redhat.stream.0,id=charchannel1
+-device virtserialport,bus=virtio-serial0.0,nr=1,chardev=charchannel1,id=channel1,name=com.redhat.spice.stream.0 -chardev spiceport,name=com.redhat.spice.stream.0,id=charchannel1
diff --git a/data/90-spice-guest-streaming.rules b/data/90-spice-guest-streaming.rules
index 6cedd5c..5f74bd9 100644
--- a/data/90-spice-guest-streaming.rules
+++ b/data/90-spice-guest-streaming.rules
@@ -1,2 +1,2 @@
-ACTION=="add", SUBSYSTEM=="virtio-ports", ENV{DEVLINKS}=="/dev/virtio-ports/com.redhat.stream.0", MODE="0666"
+ACTION=="add", SUBSYSTEM=="virtio-ports", ENV{DEVLINKS}=="/dev/virtio-ports/com.redhat.spice.stream.0", MODE="0666"
diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp
index b39782c..eb469c8 100644
--- a/src/spice-streaming-agent.cpp
+++ b/src/spice-streaming-agent.cpp
@@ -480,7 +480,7 @@ done:
int main(int argc, char* argv[])
{
- const char *streamport = "/dev/virtio-ports/com.redhat.stream.0";
+ const char *streamport = "/dev/virtio-ports/com.redhat.spice.stream.0";
int opt;
const char *log_filename = NULL;
int logmask = LOG_UPTO(LOG_WARNING);
--
2.16.2
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel