Re: [PATCH spice-streaming-agent v5 2/2] Implement handling of error messages from the server

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> On Wed, Mar 07, 2018 at 03:01:43PM +0100, Christophe de Dinechin wrote:
> > Also, on an arch like ARM. the packed attribute gives the compiler the
> > opportunity to use special mis-aligned load and store instructions. So
> > it’s a good thing, isn’t it?
> 
> Iirc the compiler was not doing that much magic last time the issue came up.
> 
> Christophe
> 

Don't exactly agree.
Was quite confusing. There were 2 patches, one to fix ARMv7 and alignment of
64 bit and one to fix old ARMv5.
We didn't have much test environment and the reply for testing was very
few so we didn't have much confirmations.
When I tried directly using a ARM machine the code and speed improved a lot.
Is confusing actually that the unaligned access code is generated only for
structures.

Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]