Re: [spice-server PATCH] stream_device_partial_read: check once if whole hdr is read

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/05/2018 06:01 PM, Frediano Ziglio wrote:

The "read header" loop checks if the whole header is read twice:
once in the while condition and once in the end of the loop body.

This patch removes the latter check and sets appropriate variables
outside of the loop.

Signed-off-by: Uri Lublin <uril@xxxxxxxxxx>

This patch does not pass "make check".
The reason is that that code is executed multiple time for the
same message if the message is send using multiple send.

You are correct. The second if should stay inside the loop so it
happens once for every message.
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]