On Thu, Mar 01, 2018 at 08:28:12PM +0100, Christophe de Dinechin wrote:
>
>
> > On 1 Mar 2018, at 11:51, Lukáš Hrázký <lhrazky@xxxxxxxxxx> wrote:
> >
> > On Wed, 2018-02-28 at 16:43 +0100, Christophe de Dinechin wrote:
> >> From: Christophe de Dinechin <dinechin@xxxxxxxxxx>
> >>
> >> It makes sense to place the codecs inside the Stream which is charged
> >> with setting it up, until we create a proper abstraction for input
> >> messages similar to what Message does for output messages in follow-up
> >> patches.
> >>
> >> Signed-off-by: Christophe de Dinechin <dinechin@xxxxxxxxxx>
> >> ---
> >> src/spice-streaming-agent.cpp | 13 +++++++++----
> >> 1 file changed, 9 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp
> >> index 4d24234..403e65c 100644
> >> --- a/src/spice-streaming-agent.cpp
> >> +++ b/src/spice-streaming-agent.cpp
> >> @@ -67,8 +67,11 @@ struct CursorMessage
> >>
> >> class Stream
> >> {
> >> + typedef std::set<SpiceVideoCodecType> codecs_t;
> >
> > Not sure I'd present a typedef for it, but that's a matter of style.
> >
> > As for the naming, normally we use CamelCase with no "_t" suffix for
> > type names, do you wish to distinguish these member typedefs like this?
>
> We use _t for typedefs ATM, I stuck with that. No strong reason to change it.
I could not find any _t typedef in spice-streaming-agent codebase
(actually, I could not find many typedefs at all ;)
Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel