> On 1 Mar 2018, at 16:27, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote:
>
> In my testing (x86_64/gcc), this had no impact on the resulting binary,
> building with/without it gives the same stripped binary save for its
> buildid.
I was also thinking that -fvisibility=hidden did not make much sense for an a.out.
Acked-by: Christophe de Dinechin <dinechin@xxxxxxxxxx>
>
> Signed-off-by: Christophe Fergeau <cfergeau@xxxxxxxxxx>
> ---
> configure.ac | 19 -------------------
> src/Makefile.am | 2 --
> 2 files changed, 21 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index e5decb3..2ab14da 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -50,25 +50,6 @@ LIBVIRT_LINKER_NO_INDIRECT
> AC_SUBST(WARN_CFLAGS)
> AC_SUBST(WARN_CXXFLAGS)
>
> -dnl =========================================================================
> -dnl -fvisibility stuff
> -
> -have_gcc4=no
> -AC_MSG_CHECKING(for -fvisibility)
> -AC_COMPILE_IFELSE([AC_LANG_SOURCE([
> -#if defined(__GNUC__) && (__GNUC__ >= 4)
> -#else
> -error Need GCC 4.0 for visibility
> -#endif
> -int main () { return 0; }
> -])], have_gcc4=yes)
> -
> -if test "x$have_gcc4" = "xyes" && test ! "$os_win32" = "yes" ; then
> - VISIBILITY_HIDDEN_CFLAGS="-fvisibility=hidden"
> -fi
> -AC_MSG_RESULT($have_gcc4)
> -AC_SUBST(VISIBILITY_HIDDEN_CFLAGS)
> -
> AC_DEFINE_DIR([BINDIR], [bindir], [Where data are placed to.])
>
> AC_OUTPUT([
> diff --git a/src/Makefile.am b/src/Makefile.am
> index 3717b5c..857d763 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -16,12 +16,10 @@ AM_CPPFLAGS = \
> $(NULL)
>
> AM_CFLAGS = \
> - $(VISIBILITY_HIDDEN_CFLAGS) \
> $(WARN_CFLAGS) \
> $(NULL)
>
> AM_CXXFLAGS = \
> - $(VISIBILITY_HIDDEN_CFLAGS) \
> $(WARN_CXXFLAGS) \
> $(NULL)
>
> --
> 2.14.3
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel