[spice-gtk v1] channel-usbredir: avoid calling memcpy() will NULL src

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Victor Toso <me@xxxxxxxxxxxxxx>

Code built with address sanitizer has runtime error:
 > channel-usbredir.c:642:5: runtime error: null pointer passed
 > as argument 2, which is declared to never be null

Signed-off-by: Victor Toso <victortoso@xxxxxxxxxx>
---
 src/channel-usbredir.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/channel-usbredir.c b/src/channel-usbredir.c
index 1f791bc..7c48ecb 100644
--- a/src/channel-usbredir.c
+++ b/src/channel-usbredir.c
@@ -635,9 +635,9 @@ static int usbredir_read_callback(void *user_data, uint8_t *data, int count)
     SpiceUsbredirChannel *channel = user_data;
     SpiceUsbredirChannelPrivate *priv = channel->priv;
 
-    if (priv->read_buf_size < count) {
-        count = priv->read_buf_size;
-    }
+    count = MIN(priv->read_buf_size, count);
+    if (count == 0)
+        return 0;
 
     memcpy(data, priv->read_buf, count);
 
-- 
2.16.2

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]