On Thu, Feb 15, 2018 at 05:06:14PM +0100, Christophe de Dinechin wrote: > From: Christophe de Dinechin <dinechin@xxxxxxxxxx> > > There are two use cases for this .clang-format: > > 1. Local reformatting of source code, e.g. using Emacs clang-format.el package. > This is basically a wawy to accelerate routine reformatting actions during 'way' > heavy editing or refactoring. > > 2. Global reformatting of the source code, e.g. using the 'make reformat' > rule in the 'build' makefiles. > > Presently, our source code is not entirely ready for this kind of > refactoring yet, mostly because several of our headers are not > self-contained, so you end up with errors like: > > In file included from agent-msg-filter.c:25: > In file included from ./red-common.h:37: > In file included from ./spice.h:27: > ./spice-migration.h:47:31: error: unknown type name 'SpiceServer' My understanding was also that this .clang-format file got the formatting wrong in some cases when applied over the codebase? > Changes since v3: > - Documented rationale and use cases in commit log > - Some setting changes to more closely match existing server practice NB: This part belongs below the -- line as this usually should not be pushed to the upstream repository
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel