> On 12 Feb 2018, at 17:58, Frediano Ziglio <fziglio@xxxxxxxxxx> wrote: > > In SPICE, as in Glib, ERROR is more "strong" than CRITICAL > (I don't know where this came, even in Solaris CRITICAL is more > strong like Linux, maybe an initial mistake). > By default CRITICAL is fatal (it calls abort) so ERROR is too. I’ve not tested with the agent, but I know that for spicy, I regularly get “CRITICAL” about assertions without an abort: (spicy:53020): GLib-GObject-CRITICAL **: g_object_get: assertion 'G_IS_OBJECT (object)' failed (spicy:53020): GLib-GObject-CRITICAL **: g_object_unref: assertion 'G_IS_OBJECT (object)' failed If the desired behavior is an abort, we are not configuring it properly. Christophe > >>> I agree, asserts should not be used as needed runtime checks. >> >> I’ll add that to the next writeup. >> > _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel