> On 8 Feb 2018, at 09:50, Frediano Ziglio <fziglio@xxxxxxxxxx> wrote: > >> >> From: Christophe de Dinechin <dinechin@xxxxxxxxxx> >> >> Signed-off-by: Christophe de Dinechin <dinechin@xxxxxxxxxx> >> --- >> docs/spice_style.txt | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/docs/spice_style.txt b/docs/spice_style.txt >> index 3e463d2f..74f4e29d 100644 >> --- a/docs/spice_style.txt >> +++ b/docs/spice_style.txt >> @@ -113,7 +113,7 @@ If multiple related constants are to be defined, consider >> the use of enumeration >> Short functions >> --------------- >> >> -Try to split code to short functions, each having simple functionality, in >> order to improve code readability and re-usability. Prefix with inline short >> functions or functions that were splitted for readability reason. >> +Try to split code to short functions, each having simple functionality, in >> order to improve code readability and re-usability. Prefix with `inline` >> functions that were splitted for readability reason or that are very short. >> >> Return on if >> ------------ > > I really don't understanding the aiming of both version. > Is mixing the inline concept (optimization suggestion) with readability > and I don't understand the reason. OK. Needs rephrasing then. I agree I did not improve much. Will do one more pass. > > Frediano > _______________________________________________ > Spice-devel mailing list > Spice-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/spice-devel _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel