>
> From: Christophe de Dinechin <dinechin@xxxxxxxxxx>
>
> The sentence explaining that example makes no real sense, and
> the coding style suggestion is horrendous (not to mention flies in the
> face of all automatic indentation tools)
>
> Signed-off-by: Christophe de Dinechin <dinechin@xxxxxxxxxx>
> ---
> docs/spice_style.txt | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/docs/spice_style.txt b/docs/spice_style.txt
> index a9d77afa..ccc60bb3 100644
> --- a/docs/spice_style.txt
> +++ b/docs/spice_style.txt
> @@ -254,15 +254,7 @@ if (condition) {
> +
> In case of long condition statement, prefer having additional temporary
> variable over multiple line condition statement.
> +
> -In case of new line in condition statement.
> -+
> -[source,c]
> -----
> -if (long_name && very_long_name && very_long ||
> - var_name) {
> -----
> -+
> -or indent under the round bracket using spaces
> +Indent long conditionals under the opening parenthesis using spaces
> +
> [source,c]
> ----
Looks like you are being too kind. Should be "Remove the ugly example" :-)
Good you pointed out.
I think the main reason should be (beside it does not look great) that
this style is not used in the code. Maybe:
"Remove confusing example
The sentence explaining that example makes no real sense, the
mentioned style is not used by current code and the coding style
suggestion is horrendous."
Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel