Christophe de Dinechin writes: >> On 30 Jan 2018, at 12:56, Frediano Ziglio <fziglio@xxxxxxxxxx> wrote: >> >>> >>> Hi Frediano, >>> >>> >>> >>>> On 30 Jan 2018, at 11:50, Frediano Ziglio <fziglio@xxxxxxxxxx> wrote: >>>> >>>> ping the series >>> >>> I’m currently looking at it. Is it supposed to fix the read errors I had when >>> restarting the streaming agent? >>> >> >> Yes, make the reset more stable. >> When you close the device the state will be more consistent allowing >> basically to kill the process using the device in any state and opening >> again. Obviously if you continue to send wrong commands the device will >> keep rejecting them. >> >> I tried to reproduce the issues reported on IRC and these helped me, >> now I avoid entirely to reboot the guest. > > OK, right now I get a QEMU crash whenever I do any kind of activity > (the keyboard seems to be what triggers it). > > I’m trying to reproduce on master to see if your patch is the cause. > That host has gone through some unusual nastiness, and may be > in a geborked state. Reverting the server to master, I am back to the behavior I had before, where the same series of events leads to DISPLAY=:1 spice-streaming-agent -c noblock=yes spice-streaming-agent[2240]: UNKNOWN msg of type 5 spice-streaming-agent[2240]: BAD VERSION 0 (expected is 1) spice-streaming-agent[2240]: BAD VERSION 108 (expected is 1) spice-streaming-agent[2240]: BAD VERSION 97 (expected is 1) spice-streaming-agent[2240]: read command from device FAILED -- read 1 expected 8 spice-streaming-agent[2240]: FAILED to read command So it looks like your patch makes the behavior worse for me, leading to a crash of QEMU and loss of that guest. I can debug if you want, but since I'm still quite behind on mail, I won't do that right away. Hope you have an idea how this happens. If not, I'll take a look. Thanks Christophe > > Will keep you posted. > > > Christophe > >> >> The tests (manual at the beginning) I did were coded into unit tests >> so you could try it and will help to avoid these conditions in the >> future. >> >>> >>> Thanks >>> Christophe >>> >> >> Frediano >> _______________________________________________ >> Spice-devel mailing list >> Spice-devel@xxxxxxxxxxxxxxxxxxxxx >> https://lists.freedesktop.org/mailman/listinfo/spice-devel > > _______________________________________________ > Spice-devel mailing list > Spice-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/spice-devel -- Cheers, Christophe de Dinechin (IRC c3d) _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel