Frediano Ziglio <fziglio@xxxxxxxxxx> wrote: > > > > Frediano Ziglio <fziglio@xxxxxxxxxx> wrote: > > > > > > Hi Frediano, > > > > > > > > On 2018-01-22 06:04 -0500, Frediano Ziglio <fziglio@xxxxxxxxxx> > > > > wrote: > > > > >> > > > > >> Hello, > > > > >> spice-gtk fails to build with LibreSSL: > > > > >> > > > > >> libtool: link: cc -o > > > > >> /usr/local/ports/deskutils/spice-gtk/work/spice-gtk-0.34/src/tmp-introspectM6aimR/.libs/SpiceClientGLib-2.0 > > > > >> -isystem /usr/local/include -I/usr/local/include -O2 -pipe > > > > >> -march=native -fstack-protector -isystem /usr/local/include > > > > >> -fno-strict-aliasing -Wl,-rpath -Wl,/usr/local/lib > > > > >> -fstack-protector > > > > >> tmp-introspectM6aimR/usr/local/ports/deskutils/spice-gtk/work/spice-gtk-0.34/src/tmp-introspectM6aimR/SpiceClientGLib-2.0.o > > > > >> -Wl,--export-dynamic -pthread -Wl,--export-dynamic > > > > >> -L/usr/local/lib > > > > >> -L. ./.libs/libspice-client-glib-2.0.so /usr/local/lib/libsasl2.so > > > > >> -lgmodule-2.0 -lgthread-2.0 -lopus -lgio-2.0 -ljpeg -lz -llz4 > > > > >> -lpixman-1 -lcrypto -lssl -lpulse-mainloop-glib -lpulse > > > > >> -lpthread -lgstaudio-1.0 -lgstapp-1.0 -lgstvideo-1.0 > > > > >> -lgstbase-1.0 -lgstreamer-1.0 -lgobject-2.0 -lglib-2.0 -lintl > > > > >> -pthread -Wl,-rpath > > > > >> -Wl,/usr/local/lib ./.libs/libspice-client-glib-2.0.so: > > > > >> undefined reference to > > > > >> `BIO_meth_set_read' ./.libs/libspice-client-glib-2.0.so: > > > > >> undefined reference to > > > > >> `BIO_get_data' ./.libs/libspice-client-glib-2.0.so: undefined > > > > >> reference to > > > > >> `BIO_meth_set_write' ./.libs/libspice-client-glib-2.0.so: > > > > >> undefined reference to > > > > >> `BIO_meth_set_ctrl' ./.libs/libspice-client-glib-2.0.so: > > > > >> undefined reference to > > > > >> `BIO_meth_set_puts' ./.libs/libspice-client-glib-2.0.so: > > > > >> undefined reference to > > > > >> `BIO_meth_free' ./.libs/libspice-client-glib-2.0.so: > > > > >> undefined reference to > > > > >> `BIO_meth_new' ./.libs/libspice-client-glib-2.0.so: > > > > >> undefined reference to > > > > >> `BIO_set_init' ./.libs/libspice-client-glib-2.0.so: > > > > >> undefined reference to > > > > >> `EVP_PKEY_get0_RSA' ./.libs/libspice-client-glib-2.0.so: > > > > >> undefined reference to > > > > >> `ASN1_STRING_get0_data' ./.libs/libspice-client-glib-2.0.so: > > > > >> undefined reference to > > > > >> `BIO_get_new_index' ./.libs/libspice-client-glib-2.0.so: > > > > >> undefined reference to `BIO_set_data' cc: error: linker > > > > >> command failed with exit code 1 (use -v to see invocation) > > > > >> > > > > >> I don't know if this is supported configuration. Fix is > > > > >> pretty simple so hopefully can be accepted. > > > > >> > > > > > > > > > >Hi, > > > > > patch looks good and similar to a lot of similar patches. > > > > > > > > Just noticed that spice-common part was left out in last patch. > > > > Missing part attached. > > > > > > > > >Can you confirm the email you are sending and the > > > > >"Signed-off-by"? > > > > > > > > Does this answer counts as confirmation? I'm not sure what is > > > > required here. Patches are signed off by me, no one else was > > > > involved. > > > > >I suppose you have problems with FreeBSD. Can you provide a > > > > >commit message? I can write a commit from your patch using you > > > > >as author if you prefer. > > > > > > > > Please do write commit log, I'm not familiar enough with the > > > > project and I don't know its conventions. > > > > > > > > > > Hi, wrote the commits, see > > > https://lists.freedesktop.org/archives/spice-devel/2018-January/041494.html > > > https://lists.freedesktop.org/archives/spice-devel/2018-January/041495.html > > > > > > Tell me if they are fine for you. > > > > Looks good, except: > > > > > FreeBSD uses LibreSSL instead of OpenSSL. > > > > FreeBSD uses OpenSSL by default, but our ports infrastructure allows > > usage of other SSL implementations if user chooses so. > > > > > > Would be > > "Some FreeBSD configurations can use LibreSSL instead of OpenSSL." > > good? Good. Our desktop derivative uses it by default for example: https://www.trueos.org/more-on-trueos/ _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel