Re: [PATCH spice-server] red-stream: Remove AsyncRead::stream

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 16, 2018 at 08:59:14AM -0500, Frediano Ziglio wrote:
> Yes, is handling a particular case (reading 0 bytes) directly instead of
> adding a pending operation. It can be useful if you have a sequence length+data
> where length can be 0. Currently cannot happen (size is always > 0), in
> red_sasl_handle_auth_steplen where you have a sequence like that you handle
> the size == 0 case explicitly with a "if (len == 0) {".
> 
> But you are right, is not part of the rationale although IMHO should be a
> handled case. I'll remove from the patch.

I'm totally fine with this change in a separate patch, I just don't want
the commit under review to change behaviour.

Christophe

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]