> > OK. Unrelated, but it would be nice to have a little documentation > about what RedUpgradeItem is actually used for... > > Acked-by: Jonathon Jongsma <jjongsma@xxxxxxxxxx> > > Is used to send a full quality image of the area where the stream was. The code is in dcc-send.c. Yes, looks weird but basically all the rendering is done by dcc-send ! A draw_copy message (see spice.proto) is sent to the client with the last "frame". Frediano > On Fri, 2017-12-08 at 15:55 +0000, Frediano Ziglio wrote: > > This structure is used to send a message related to streams. > > There are already other items defined in video-stream.h so > > move the declaration. > > > > Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx> > > --- > > This is a long attempt to remove the need to include > > display-channel-private.h inclusion in video-stream.c > > --- > > server/display-channel-private.h | 6 ------ > > server/video-stream.h | 6 ++++++ > > 2 files changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/server/display-channel-private.h b/server/display- > > channel-private.h > > index 24fa42b1..617ce30d 100644 > > --- a/server/display-channel-private.h > > +++ b/server/display-channel-private.h > > @@ -178,12 +178,6 @@ typedef struct RedSurfaceDestroyItem { > > SpiceMsgSurfaceDestroy surface_destroy; > > } RedSurfaceDestroyItem; > > > > -typedef struct RedUpgradeItem { > > - RedPipeItem base; > > - Drawable *drawable; > > - SpiceClipRects *rects; > > -} RedUpgradeItem; > > - > > static inline int is_equal_path(SpicePath *path1, SpicePath *path2) > > { > > SpicePathSeg *seg1, *seg2; > > diff --git a/server/video-stream.h b/server/video-stream.h > > index 2dfcf7bf..cf912152 100644 > > --- a/server/video-stream.h > > +++ b/server/video-stream.h > > @@ -45,6 +45,12 @@ > > > > typedef struct VideoStream VideoStream; > > > > +typedef struct RedUpgradeItem { > > + RedPipeItem base; > > + Drawable *drawable; > > + SpiceClipRects *rects; > > +} RedUpgradeItem; > > + > > typedef struct RedStreamActivateReportItem { > > RedPipeItem pipe_item; > > uint32_t stream_id; > _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel