Re: [spice-server 1/2] worker: Remove unneeded include

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 08, 2017 at 09:00:34AM -0500, Frediano Ziglio wrote:
> > 
> > Nothing seems to be using openssl in red-worker.c
> > 
> 
> There are direct call to OpenSSL. Search for "SSL_".
> But openssl/ssl.h is included in red-stream.h which is
> included everywhere :-(

I do not have these here:

$ grep SSL_ server/red-worker.c
$


> I would avoid the include in such a global header just for SSL_CTX
> (which is used) but in the other hand I don't like using a "void *"
> or a "struct ssl_ctx_st *" which I'm not sure is always defined that
> way.

There is only one caller of the only user of SSL_CTX in that header, so
we could move this to a dedicated header, but probably overkill just to
avoid some #include

Christophe

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]