Re: [PATCH spice-server 4/9] main-channel: Remove useless check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 05, 2017 at 08:41:07AM +0000, Frediano Ziglio wrote:
> If there is a channel client there's surely a related channel.
> 
> Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx>

Acked-by: Victor Toso <victortoso@xxxxxxxxxx>

> ---
>  server/main-channel.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/server/main-channel.c b/server/main-channel.c
> index 43ab39ae..f5c079f3 100644
> --- a/server/main-channel.c
> +++ b/server/main-channel.c
> @@ -165,7 +165,6 @@ static bool main_channel_handle_message(RedChannelClient *rcc, uint16_t type,
>                                          uint32_t size, void *message)
>  {
>      RedChannel *channel = red_channel_client_get_channel(rcc);
> -    MainChannel *main_chan = MAIN_CHANNEL(channel);
>      MainChannelClient *mcc = MAIN_CHANNEL_CLIENT(rcc);
>      RedsState *reds = red_channel_get_server(channel);
>  
> @@ -174,9 +173,6 @@ static bool main_channel_handle_message(RedChannelClient *rcc, uint16_t type,
>          SpiceMsgcMainAgentStart *tokens;
>  
>          spice_printerr("agent start");
> -        if (!main_chan) {
> -            return FALSE;
> -        }
>          tokens = (SpiceMsgcMainAgentStart *)message;
>          reds_on_main_agent_start(reds, mcc, tokens->num_tokens);
>          break;
> -- 
> 2.14.3
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/spice-devel

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]