On Wed, Nov 29, 2017 at 5:03 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote:
> On Mon, Nov 13, 2017 at 06:50:05PM +0100, Jakub Janků wrote:
>> This is a preparatory patch for GTK+ vdagent redesign.
>>
>> Since most of the vdagent code still uses X11 lib,
>> force GDK to use X11 backend by calling
>> gdk_set_allowed_backends("x11").
>
> What happens if the agent tries to use gtk+, and this call is not
> present?
>
> Christophe
> On Mon, Nov 13, 2017 at 06:50:05PM +0100, Jakub Janků wrote:
>> This is a preparatory patch for GTK+ vdagent redesign.
>>
>> Since most of the vdagent code still uses X11 lib,
>> force GDK to use X11 backend by calling
>> gdk_set_allowed_backends("x11").
>
> What happens if the agent tries to use gtk+, and this call is not
> present?
>
> Christophe
I'll fix this in the next version, I was waiting for reviews of the other patches (2/3, 3/3).
gdk_set_allowed_backends() was added in v3.10. Prior to this version, GDK_IS_X11_DISPLAY() should be used after gtk_init() to make sure we are using X11.
Or would anyone be against requiring GTK+ v3.10?
Cheers,
Jakub
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel