Re: [PATCH spice-streaming-agent v2 2/2] Rework option handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 16, 2017 at 10:17:28AM -0500, Frediano Ziglio wrote:
> > 4. It delegates usage information to the plugins, so that each plugin
> >    can document its specific options in a consistent way.
> > 
> > 5. It cleans up some confusing or surprising aspects of the interace,
> >    notably null-terminated option vectors and the ownership of
> >    dynamically loaded plugins.
> > 
> > Signed-off-by: Christophe de Dinechin <dinechin@xxxxxxxxxx>
> 
> Maybe you should split the patch instead of having multiple points
> inside the comment? I would personally starts with some commit that
> can be merged without waiting, like adding a Name() method.

Yes, that was my reaction when reading through it, this is trying to do far too
much in one commit.

Christophe

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]