Hey, On Wed, Nov 08, 2017 at 08:20:12AM +0000, Frediano Ziglio wrote: > Missing some names cause some debugging messages to be > generated and some of our tests to fail. Something I wanted to check before sending this patch is if the commit adding human-readable channel did not cause a small regression when using spice-server to create a channel whose type is not known. This can happen in somehow valid situations, if spice-protocol has a new channel type, which code tries to use, when it hasn't been added to spice-server yet. I'd even add a test case for that actually. Christophe > > This patch was written by Christophe Fergeau. > > Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx> > --- > server/utils.c | 2 ++ > 1 file changed, 2 insertions(+) > > Tested with Gitlab, see https://gitlab.com/freddy77/spice/-/jobs/39471945 > > diff --git a/server/utils.c b/server/utils.c > index e25b7891..ff1fc2d1 100644 > --- a/server/utils.c > +++ b/server/utils.c > @@ -58,8 +58,10 @@ static const char *const channel_names[] = { > [ SPICE_CHANNEL_CURSOR ] = "cursor", > [ SPICE_CHANNEL_PLAYBACK ] = "playback", > [ SPICE_CHANNEL_RECORD ] = "record", > + [ SPICE_CHANNEL_TUNNEL ] = "tunnel", > [ SPICE_CHANNEL_SMARTCARD] = "smartcard", > [ SPICE_CHANNEL_USBREDIR ] = "usbredir", > + [ SPICE_CHANNEL_PORT ] = "port", > [ SPICE_CHANNEL_WEBDAV ] = "webdav", > }; > > -- > 2.13.6 >
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel