Re: [3/6] [PATCH spice] Add horizontal mouse wheel support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 30, 2017 at 10:22:40PM +0800, Matthew J. Francis wrote:
> On 30/10/2017 17:28, Frediano Ziglio wrote:
> > This patch changes ABI so would need a version bump and a Qemu patch.
> > Did you send a patch to Qemu too?
> 
> As mentioned in the patch overview, I haven't touched qemu yet - if I
> can get agreement on what the API/ABI should look like from the SPICE
> end, I will work on that next.
> 
> > Maybe some capability and usage of some bits in wheel_motion could do
> > instead of we could add an additional function in SpiceTabletInstance/SpiceMouseInterface
> > to have a compatible ABI.
> 
> I considered three options for this in total, each of which has some
> advantages and disadvantages
> 
> 1) Change the existing API (as in the posted patch)
>    + Gives the cleanest code on the SPICE server side
>    - ABI incompatible, code that links against it must update in step

For what it's worth, an ABI break is definitely not an option.
Raising the version number of the mouse/tablet SpiceInterface
and introducing new behaviour on such interfaces could work.
Given that wayland client only supports smooth scrolling, I suspect
we'll want to go with new methods supporting smooth scrolling.

Christophe

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]