Re: [PATCH spice-gtk v2] spicy: Add call of gst_deinit at program exit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> Hi
> 
> ----- Original Message -----
> > From: Christophe de Dinechin <dinechin@xxxxxxxxxx>
> > 
> > This is useful for some instrumentation, e.g. the leaks tracer,
> > that perform some of their operations within gst_deinit.
> > 
> > Without this patch, if you run spicy with
> > 	GST_DEBUG="GST_TRACER:7" GST_TRACERS="leaks" spicy ...
> > the leak tracer does not show any output, because it runs in gst_deinit.
> > 
> > Signed-off-by: Christophe de Dinechin <dinechin@xxxxxxxxxx>
> 
> Reviewed-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
> 

Ack for me

> > ---
> >  tools/spicy.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/tools/spicy.c b/tools/spicy.c
> > index 088e034..d79e504 100644
> > --- a/tools/spicy.c
> > +++ b/tools/spicy.c
> > @@ -2068,5 +2068,8 @@ int main(int argc, char *argv[])
> >      g_free(spicy_title);
> >  
> >      setup_terminal(true);
> > +#if HAVE_GSTAUDIO || HAVE_GSTVIDEO
> > +    gst_deinit();
> > +#endif
> >      return 0;
> >  }

Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]