On Mon, Oct 16, 2017 at 4:07 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > My understanding is that the short log really should be saying "oVirt CI > support" rather than "standard CI support". Changed to 'standard oVirt CI support' and added a link. oVirt has also non-standard CI, which is currently used for a few projects, including ovirt-wgt/spice-nsis, which we want to get rid of. That's the motivation for current patch. > Has gitlab built-in CI been considered for this work? No. > In other words, > why use oVirt for CI rather than something more "standard"? I don't mind at all looking at gitlab CI, assuming I can find enough time... We have a large CI infrastructure in oVirt, which I have a feeling is more than gitlab currently provides (or intends to), including integration testing for compositions of builds of different projects etc. This does not (yet?) cover ovirt-wgt/spice-nsis, so no direct advantage for now. > > Where would the error messages go if CI fails? oVirt gerrit. This includes an email to every reviewer of the patch there. You can add ovirt-wgt to your Watched Projects if you want to get these automatically. > Are there any sanity > checks done on the generated packages? Not yet. All we currently have is current patch. > Or is this just testing the > build? Indeed. > > Christophe > > On Mon, Oct 16, 2017 at 03:59:27PM +0300, Yedidyah Bar David wrote: >> From: Sandro Bonazzola <sbonazzo@xxxxxxxxxx> >> >> This patch was previously merged in ovirt gerrit with Change-Id >> Ie16cc0902c4393e62b074661a86f2f5bb9a1efc1, but removed from master >> branch there for review on spice-devel. >> >> Change-Id: I042f30d87b0730ae76e2c8b537e46a56cbbf65f7 >> Signed-off-by: Sandro Bonazzola <sbonazzo@xxxxxxxxxx> >> --- >> automation/build-artifacts.packages | 15 +++++++++++++++ >> automation/build-artifacts.repos | 3 +++ >> automation/build-artifacts.sh | 23 +++++++++++++++++++++++ >> automation/check-patch.packages | 1 + >> automation/check-patch.repos | 1 + >> automation/check-patch.sh | 3 +++ >> 6 files changed, 46 insertions(+) >> create mode 100644 automation/build-artifacts.packages >> create mode 100644 automation/build-artifacts.repos >> create mode 100755 automation/build-artifacts.sh >> create mode 120000 automation/check-patch.packages >> create mode 120000 automation/check-patch.repos >> create mode 100755 automation/check-patch.sh >> >> diff --git a/automation/build-artifacts.packages b/automation/build-artifacts.packages >> new file mode 100644 >> index 0000000..5da3536 >> --- /dev/null >> +++ b/automation/build-artifacts.packages >> @@ -0,0 +1,15 @@ >> +make >> +mingw32-nsis >> +mingw32-spice-vdagent >> +mingw64-spice-vdagent >> +ovirt-guest-agent-windows >> +vcredist-x86 >> +virtio-win >> +nsis-simple-service-plugin >> +git >> +genisoimage >> +rsync >> +hardlink >> +p7zip >> +p7zip-plugins >> +yum-utils >> diff --git a/automation/build-artifacts.repos b/automation/build-artifacts.repos >> new file mode 100644 >> index 0000000..6e168a4 >> --- /dev/null >> +++ b/automation/build-artifacts.repos >> @@ -0,0 +1,3 @@ >> +ovirt-master-snapshot,http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/$distro >> +ovirt-master-snapshot-static,http://resources.ovirt.org/pub/ovirt-master-snapshot-static/rpm/$distro >> +virtio-win,https://fedorapeople.org/groups/virt/virtio-win/repo/latest >> diff --git a/automation/build-artifacts.sh b/automation/build-artifacts.sh >> new file mode 100755 >> index 0000000..4a19783 >> --- /dev/null >> +++ b/automation/build-artifacts.sh >> @@ -0,0 +1,23 @@ >> +#!/bin/bash -xe >> +[[ -d exported-artifacts ]] \ >> +|| mkdir -p exported-artifacts >> + >> +[[ -d tmp.repos/SOURCES ]] \ >> +|| mkdir -p tmp.repos/SOURCES >> + >> +make dist >> +yum-builddep -y ovirt-guest-tools-iso.spec >> + >> +rpmbuild \ >> + -D "_topdir $PWD/tmp.repos" \ >> + -ta *.tar.bz2 >> + >> +find \ >> + "$PWD/tmp.repos" \ >> + -iname \*.rpm \ >> + -exec mv {} exported-artifacts/ \; >> + >> +find \ >> + "$PWD/tmp.repos" \ >> + -iname \*.iso \ >> + -exec mv {} exported-artifacts/ \; >> diff --git a/automation/check-patch.packages b/automation/check-patch.packages >> new file mode 120000 >> index 0000000..1903cac >> --- /dev/null >> +++ b/automation/check-patch.packages >> @@ -0,0 +1 @@ >> +build-artifacts.packages >> \ No newline at end of file >> diff --git a/automation/check-patch.repos b/automation/check-patch.repos >> new file mode 120000 >> index 0000000..3d35b4f >> --- /dev/null >> +++ b/automation/check-patch.repos >> @@ -0,0 +1 @@ >> +build-artifacts.repos >> \ No newline at end of file >> diff --git a/automation/check-patch.sh b/automation/check-patch.sh >> new file mode 100755 >> index 0000000..780366d >> --- /dev/null >> +++ b/automation/check-patch.sh >> @@ -0,0 +1,3 @@ >> +#!/bin/bash -xe >> + >> +./automation/build-artifacts.sh >> -- >> 1.8.3.1 >> >> _______________________________________________ >> Spice-devel mailing list >> Spice-devel@xxxxxxxxxxxxxxxxxxxxx >> https://lists.freedesktop.org/mailman/listinfo/spice-devel -- Didi _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel