> > On Fri, Oct 06, 2017 at 11:58:32AM +0100, Frediano Ziglio wrote: > > This function does not make much sense anymore. > > Is called by RedVmcChannel which doesn't use RedChannelClient ACKs > > so the variable changed are not used. > > > > Also is called when the channel is constructed to set client > > fields however at that stage there are no clients. > > I'm not seeing this channel construction code in master? > I'm referring to red_vmc_channel_constructed code. Maybe I should specify the channel? Is in the previous paragraph. > > > > Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx> > > --- > > Note that now red_channel_client_init_outgoing_messages_window > > is not used anymore. > > On the other hand this function is really similar to > > red_channel_client_ack_zero_messages_window but IMHO has a better > > name. Would prefer a follow up to unify > > red_channel_client_init_outgoing_messages_window and > > red_channel_client_ack_zero_messages_window names and behaviour. > > Would definitely make sense, especially as I'm not convinced > smartcard.c/spicevmc.c should call > red_channel_client_ack_zero_messages_window() as they don't handle acks. > Yes, was the "Is called by RedVmcChannel which doesn't use RedChannelClient ACKs". The mentioned functions are really similar. > Looks good to me, > Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx> > > Christophe > Frediano _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel