On Wed, Oct 11, 2017 at 11:30:38AM +0100, Frediano Ziglio wrote:
> Some release of ImageMagick contains a bug in compare
> utility which uses uninitialized data.
> This currently happens on Fedora 25 and 26.
nack, this happens to fix it on a specific scenario, there is absolutely
no guarantee this is going to "work" everywhere.
Let's fix imagemagick instead. If that's a very big issue, we can
disable this test for problematic imagemagik versions.
Christophe
>
> Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx>
> ---
> test-png | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/test-png b/test-png
> index ee9d86e..e942831 100755
> --- a/test-png
> +++ b/test-png
> @@ -18,7 +18,9 @@ verbose() {
> }
>
> compare_images() {
> - DIFF=$(compare -metric AE $1 $2 - 2>&1 > /dev/null || true)
> + # MALLOC_PERTURB_ is to workaround a bug in some compare versions
> + # which use some uninitialized data
> + DIFF=$(MALLOC_PERTURB_=255 compare -metric AE $1 $2 - 2>&1 > /dev/null || true)
> if [ "$DIFF" != "0" ]; then
> error "Images $1 and $2 are too different, diff $DIFF"
> fi
> --
> 2.13.6
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel