Re: [PATCH spice-server 11/16] tests: Update README

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 04, 2017 at 11:57:19AM +0100, Frediano Ziglio wrote:
> Update tests names.
> Remove tetris comments, never available and not planned.
> Update some notes.
> 
> Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx>
> ---
>  server/tests/README | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/server/tests/README b/server/tests/README
> index 27248537..84692675 100644
> --- a/server/tests/README
> +++ b/server/tests/README
> @@ -1,29 +1,29 @@
>  What is here
>  ============
>  
> -This directory will contain a testsuite for the server including tetris drawing.
> +This directory will contain a testsuite for the server.
>  
> -Unfortunately tetris and most of the tests are not here right now. You can however run all the tests and use libtool to debug any of them thus:
> +You can run all the tests and use libtool to debug any of them thus:

The 'thus' was already there, but looks odd to me (?).

>  
> -libtool --mode=execute gdb test_just_sockets_no_ssl
> +libtool --mode=execute gdb test-just-sockets-no-ssl
>  
>  Overview of tests
>  =================
>  
> -test_just_sockets_no_ssl
> +test-just-sockets-no-ssl
>   A complete server, only provides the main and inputs channels. Doesn't actually produce anything on the channels. Essentially a test of the regular link code (reds.c), good for multiple connect/disconnect tests.
>  
> -test_empty_success
> +test-empty-success
>   tests calling
>  
> -test_fail_on_null_core_interface
> +test-fail-on-null-core-interface
>   should abort when run (when spice tries to watch_add)
>  
> -basic_event_loop.c
> - used by test_just_sockets_no_ssl, can be used by other tests. very crude event loop. Should probably use libevent for better tests, but this is self contained.
> +basic-event-loop.c
> + event loop to provide core interface.
>  
>  Automated tests
>  ===============
>  
> -test_display_streaming.c
> - this test can be used to check regressions. For this, Spice needs to be compiled with --enable-automated-tests and test_display_streaming needs to be called passing --automated-tests as parameter
> +test-display-streaming.c
> + this test can be used to check regressions. For this, Spice needs to be compiled with --enable-automated-tests and test-display-streaming needs to be called passing --automated-tests as parameter

Isn't --enable-automated-tests not needed since the previous commit?

Apart from this,
Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx>

Christophe
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]