Re: [PATCH spice-server v2 0/6] Improve pipe handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



For the series,
Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx>
I had comments to one or 2 patches though.

Christophe

On Mon, Sep 04, 2017 at 12:02:04PM +0100, Frediano Ziglio wrote:
> This series does 2 changes handling the items on client pipe:
> - do not push items too much, is not needed anymore and
>   cause just network fragmentation;
> - instead of duplicating messages in the queue keep a
>   reference to the same item using reference counting.
> 
> Changes since v1:
> - added a comment to red_channel_pipes_add;
> - added a patch to take advantage of this series to
>   remove an object used internally by CursorChannel
>   (more an add on on the series).
> 
> Frediano Ziglio (6):
>   red-channel-client: Remove push call where not necessary
>   red-channel: Add red_channel_pipes_add function
>   Use new red_channel_pipes_add instead of red_channel_pipes_new_add
>   red-channel: Reuse red_channel_pipes_add
>   red-channel: Do not push data calling red_channel_pipes_new_add_push
>   cursor-channel: Use a single RedCursorPipeItem to hold the cursor
> 
>  server/cursor-channel.c      | 108 +++++++++++++------------------------------
>  server/display-channel.c     |   4 +-
>  server/inputs-channel.c      |   9 ++--
>  server/main-channel-client.c |  13 ++----
>  server/main-channel-client.h |  14 +-----
>  server/main-channel.c        |  16 ++-----
>  server/red-channel-client.c  |  12 +++--
>  server/red-channel-client.h  |   1 +
>  server/red-channel.c         |  43 ++++++++---------
>  server/red-channel.h         |   9 +++-
>  10 files changed, 83 insertions(+), 146 deletions(-)
> 
> -- 
> 2.13.5
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]