Re: [spice-server 1/3] channel: Call red_channel_disconnect_if_pending_send() from red_channel_wait_all_sent()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> On Fri, Sep 01, 2017 at 06:19:28AM -0400, Frediano Ziglio wrote:
> > > 
> > > red_channel_disconnect_if_pending_send() and red_channel_wait_all_sent()
> > > are
> > > always called together, we can remove one of the 2 methods.
> > > 
> > 
> > Looks a good idea but I think that the function deserve a new name
> 
> I would not know how to change the name though :-/
> 

Mumble... red_channel_goodbye_bad_guys ? :-)
More serious red_channel_disconnect_slow_clients.

> > 
> > Did you notice the function is always called with the same second
> > parameter?
> > Does it make sense to pass it?
> 
> Ah no, I did not pay attention to that at all, I'll take a closer look
> ;)
> 
> Christophe
> 

Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]