On Wed, Aug 30, 2017 at 03:31:46AM -0400, Frediano Ziglio wrote: > > This is an alternate proposal to the patch Frediano sent recently which > > includes the data argument in the ClientCbs struct and removes the > > g_object_get|set_data() calls. > > > > This series also removes the GObject data stuff, but also does some > > deeper refactoring. > > > > > Honestly does not seem that great. > > It assumes CursorChannel and DisplayChannel will always have an > associated QXL device. There are different patches that remove this > needs for CursorChannel. It seems this comment mostly applies to patch 2/4 which removes dispatcher = g_object_get_data(.., "dispatcher"); in favour of getting it from CommonGraphicsChannel::qxl? Or do you also object to moving from ClientCbs to virtual functions? [snip] > > Also make harder to understand why these calls are separate > as they are just some different methods while before were > contained in a different structure. I'm not sure I understand what you mean here. Christophe _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel