> > I would propagate the types, something like this: > > https://cgit.freedesktop.org/~fziglio/spice-server/commit/?h=teuf2&id=6930f008fd0dcbffc9e0c7a47e49dcdd1013b1e1 > > Beside that, > > Acked-by: Frediano Ziglio <fziglio@xxxxxxxxxx> > Updated version of proposed fixup at https://cgit.freedesktop.org/~fziglio/spice-server/commit/?h=teuf2&id=36645ef6df6ee92aa36db10448bc9c4278ad8128 Should I merge the original and post the proposal as a separate patch? Frediano > > > > Some RedChannelClient data members were marked as int when they only > > hold booleans. > > > > Signed-off-by: Christophe Fergeau <cfergeau@xxxxxxxxxx> > > --- > > Changes since v1: > > - use bool instead of gboolean > > - changed one preexisting gboolean ('destroying') > > > > > > server/red-channel-client.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/server/red-channel-client.c b/server/red-channel-client.c > > index a86833d..2dc3b26 100644 > > --- a/server/red-channel-client.c > > +++ b/server/red-channel-client.c > > @@ -133,15 +133,15 @@ struct RedChannelClientPrivate > > } urgent; > > } send_data; > > > > - int during_send; > > + bool during_send; > > GQueue pipe; > > > > RedChannelCapabilities remote_caps; > > - int is_mini_header; > > - gboolean destroying; > > + bool is_mini_header; > > + bool destroying; > > > > - int wait_migrate_data; > > - int wait_migrate_flush_mark; > > + bool wait_migrate_data; > > + bool wait_migrate_flush_mark; > > > > RedChannelClientLatencyMonitor latency_monitor; > > RedChannelClientConnectivityMonitor connectivity_monitor; _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel