Not me. Reviewing by mail is fine with me. Actually, Im concerned that if we switch to PR/MR, then some comments will end up being made only there, which is why I asked if there was a way to forward these comments to the mailing list. I believe this is possible from the group administration (its certainly possible for individual accounts on gitlab).
No, that’s not correct (at least for me). The review itself can happen over mail, what I find inefficient is: a) to get the list of things to review, and b) to get a working version of the code after patching For a), email is good to notify you of recent reviews posted. But searching through e-mail for unreviewed stuff is not easy. Do you have a good trick for that? For b), Im not talking about git am. You may not realize that just figuring out which of our 17 repositories (not including personal ones) some particular patch applies to is not always obvious. Im pretty sure this is not so much of a problem when you have worked longer on the project, so I am bringing that up precisely because Im still fresh enough to remember this being an issue.
First things first, if we want to try MR/PR, we should switch to gitlab as the primary. I understand there was a desire to do that also because freedesktop user creation was slow. Would this be a valid first step?
|
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel