On Wed, Jul 26, 2017 at 11:38:08AM +0100, Frediano Ziglio wrote:
> LTO option allows to have smaller executable stripping
> unneeded part of code.
> These options were added by a095f4806e ("build-sys: statically
> build agent").
> The gain of using these options currently are quite small,
> from a small test:
>
> $ ll *.exe
> -rwxrwxr-x. 1 freddy freddy 506880 Jul 26 11:26 vdagent.exe
> -rwxrwxr-x. 1 freddy freddy 198656 Jul 26 11:26 vdservice.exe
>
> $ ll *.exe
> -rwxrwxr-x. 1 freddy freddy 509952 Jul 26 11:26 vdagent.exe
> -rwxrwxr-x. 1 freddy freddy 200192 Jul 26 11:26 vdservice.exe
>
> Considering that there are some bug in some recent MinGW distributions
> like https://bugzilla.redhat.com/show_bug.cgi?id=1475237 and
> the small gain I would disable these options.
Small gain is still a good gain. But yeah, in light of these bugs,
we can disable it (one could argue that we could use CXXFLAGS=-fno-lto
on the buggy platforms instead).
Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx>
Christophe
>
> Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx>
> ---
> Makefile.am | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index 40db903..7fafb8b 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -4,7 +4,6 @@ MAINTAINERCLEANFILES = mingw-spice-vdagent.spec
>
> DIST_SUBDIRS = spice-protocol
>
> -AM_CXXFLAGS = -flto -fwhole-program
> AM_CPPFLAGS = \
> -DUNICODE \
> -D_UNICODE \
> --
> 2.13.3
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel