Re: [spice-common 01/14] quic: Use #define rather than static const int

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> quic.c is checking at compile-time that 'evol' is 1, 3 or 5. This is a
> constant, so a static check should be good, but my compiler (gcc 7.1.1)
> is unable to know 'evol' value at compile-time. Since the removal of
> spice_static_assert in favour of SPICE_VERIFY, this causes a
> compile-time failure.
> ---
>  common/quic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/quic.c b/common/quic.c
> index c188ed2..b7d8347 100644
> --- a/common/quic.c
> +++ b/common/quic.c
> @@ -179,7 +179,7 @@ static const int wmimax = DEFwmimax;
>  static const int wminext = DEFwminext;
>  
>  /* model evolution mode */
> -static const int evol = DEFevol;
> +#define evol DEFevol
>  
>  /* bppmask[i] contains i ones as lsb-s */
>  static const unsigned long int bppmask[33] = {

Why not using directly DEFevol ?

Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]